bump uwsgi to 2.0.26 + Python to 3.12.3
#4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
added
pr:no public docs
joeyorlando
changed the title
uwsgi to 2.0.26uwsgi to 2.0.26 + Python to 3.12.4
joeyorlando
commented
Jun 10, 2024
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.11.4" |
There was a problem hiding this comment.
decided to refactor this action file, because of this line.. now we only have our backend Python version defined in one location for our GitHub Actions workflows, here in .github/actions/setup-python/action.yml
see renamed .github/workflows/snyk-security-scan.yml file above ☝️
joeyorlando
commented
Jun 10, 2024
engine/Dockerfile
Outdated
| @@ -18,13 +18,13 @@ RUN apk add bash \ | |||
|
|
|||
| WORKDIR /etc/app | |||
| COPY ./requirements.txt ./ | |||
| COPY ./grpcio-1.57.0-cp311-cp311-linux_aarch64.whl ./ | |||
| COPY ./grpcio-1.64.1-cp312-cp312-manylinux_2_17_aarch64.whl ./ | |||
There was a problem hiding this comment.
the grpcio==1.57.0 package doesn't have any distributions built for Python 3.12 (pypi files available for 1.57.0).. so therefore decided to bump this to latest version available.
joeyorlando
commented
Jun 10, 2024
| @@ -142,7 +142,7 @@ def delete_thread_message_from_resolution_note( | |||
|
|
|||
| STEPS_ROUTING: ScenarioRoute.RoutingSteps = [ | |||
| typing.cast( | |||
| ScenarioRoute.EventCallbackChannelMessageScenarioRoute, | |||
| ScenarioRoute.EventCallbackScenarioRoute, | |||
joeyorlando
changed the title
uwsgi to 2.0.26 + Python to 3.12.4uwsgi to 2.0.26 + Python to 3.12.3
joeyorlando
changed the title
uwsgi to 2.0.26 + Python to 3.12.3uwsgi to 2.0.26 + Python to 3.12.3
joeyorlando
commented
Jun 10, 2024
Comment on lines
+39
to
+45
| opentelemetry-sdk==1.25.0 | ||
| opentelemetry-api==1.25.0 | ||
| opentelemetry-exporter-otlp-proto-grpc==1.25.0 | ||
| opentelemetry-instrumentation-logging==0.46b0 | ||
| opentelemetry-instrumentation-wsgi==0.46b0 | ||
| opentelemetry-instrumentation-requests==0.46b0 | ||
| opentelemetry-instrumentation-django==0.46b0 |
There was a problem hiding this comment.
the opentelemetry packages weren't working on 3.12 so bumped them to a newer version
https://github.com/grafana/oncall/actions/runs/9451161174/job/26031450875?pr=4495#step:5:24
joeyorlando
commented
Jun 10, 2024
| @@ -0,0 +1 @@ | |||
| *.whl filter=lfs diff=lfs merge=lfs -text | |||
There was a problem hiding this comment.
needed for this, otherwise when trying to commit the new .whl file, I ended up with this:
❯ git push origin jorlando/update-uwsgi-version
Uploading LFS objects: 100% (1/1), 113 MB | 0 B/s, done.
Enumerating objects: 13, done.
Counting objects: 100% (13/13), done.
Delta compression using up to 10 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (10/10), 107.23 MiB | 17.12 MiB/s, done.
Total 10 (delta 5), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (5/5), completed with 3 local objects.
remote: error: Trace: 015ee68316c493da0756d3d6e06c403ad8d97b15f1496100acff905654bed8d2
remote: error: See https://gh.io/lfs for more information.
remote: error: File engine/grpcio-1.64.1-cp312-cp312-linux_aarch64.whl is 107.75 MB; this exceeds GitHub's file size limit of 100.00 MB
remote: error: GH001: Large files detected. You may want to try Git Large File Storage - https://git-lfs.github.com.
To github.com:grafana/oncall.git
! [remote rejected] jorlando/update-uwsgi-version -> jorlando/update-uwsgi-version (pre-receive hook declined)
error: failed to push some refs to 'github.com:grafana/oncall.git'
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
force-pushed
the
jorlando/update-uwsgi-version
branch
from
4352d99 to
bbfeb3e
Compare
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
commented
Jun 10, 2024
docker-compose-developer.yml
Outdated
There was a problem hiding this comment.
WARN[0002] /Users/joeyorlando/coding/grafana/oncall/docker-compose-developer.yml: `version` is obsolete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
uwsgito latest version (2.0.26), which unblocks us from bumping Python to 3.12AttributeErrors in our tests that went from a warning to an error in Python 3.12 (see Prevent prefix "called_" for methods on mock objects in safe mode python/cpython#100690)Which issue(s) this PR closes
Closes #4358
Closes #4387