Tweaks to overrides (added draggable bounds, take timezone into consideration) #4553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodosii
added
pr:no public docs
teodosii
force-pushed
the
rares/overrides-timezones
branch
from
b5f4dd5 to
7977095
Compare
teodosii
commented
Jun 20, 2024
| await expect(startEl.getByTestId('date-time-picker').getByRole('textbox')).toHaveValue('23:00'); | ||
| await expect(endEl.getByTestId('date-time-picker').getByRole('textbox')).toHaveValue('09:00'); | ||
|
|
||
| async function changeDatePickerTime(element: Locator, value: string) { |
There was a problem hiding this comment.
In future iterations some parts will be reused, but for now I'll leave it like this
brojd
reviewed
Jun 21, 2024
grafana-plugin/src/containers/RotationForm/ScheduleOverrideForm.tsx
Outdated
Show resolved
Hide resolved
brojd
reviewed
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Part of #4428
Which issue(s) this PR closes
Closes #4547