fix outgoing webhook form race condition which causes integrations to sometimes not be populated #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
added
pr:no public docs
joeyorlando
commented
Jul 9, 2024
Comment on lines
62
to
64
| if (loaderStore.isLoading(ActionKey.FETCH_INTEGRATION_CHANNELS)) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
basically this is the main change here, along with wrapping this component in observer
brojd
approved these changes
Jul 10, 2024
joeyorlando
deleted the
jorlando/fix-outgoing-webhook-form-race-condition
branch
brojd
added a commit
that referenced
this pull request
Sep 18, 2024
… sometimes not be populated (#4647) # Which issue(s) this PR closes Closes grafana/support-escalations#11299 ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes. --------- Co-authored-by: Dominik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR closes
Closes https://github.com/grafana/support-escalations/issues/11299
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.