Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redis sentinel #5104

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

feat: add redis sentinel #5104

wants to merge 2 commits into from

Conversation

daddyy
Copy link

@daddyy daddyy commented Oct 1, 2024

What this PR does

Which issue(s) this PR closes

Related to #2312 #4360

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2024

CLA assistant check
All committers have signed the CLA.

@daddyy daddyy force-pushed the redis_sentinel branch 3 times, most recently from d877765 to f2874f6 Compare October 1, 2024 09:28
@daddyy daddyy marked this pull request as ready for review October 1, 2024 09:36
@daddyy daddyy requested a review from a team October 1, 2024 09:36
@daddyy daddyy changed the title feat: add sentinel to helm tmeplategit reset feat: add redis sentinel Oct 1, 2024
@daddyy daddyy force-pushed the redis_sentinel branch 23 times, most recently from 01110fb to 2f95777 Compare October 8, 2024 11:56
@daddyy daddyy force-pushed the redis_sentinel branch 4 times, most recently from 46faca7 to 77e48c0 Compare October 8, 2024 12:05
@daddyy
Copy link
Author

daddyy commented Oct 8, 2024

Sorry for the delay and for not marking it as a draft earlier. I believe the code is now ready for review.

daddyy added 2 commits October 8, 2024 14:08
Refactor the Redis configuration in the base settings file. The changes include adding support for Redis Sentinel for high availability and failover. The `REDIS_SENTINELS`, `REDIS_SENTINEL_MASTER_NAME`, and `REDIS_SENTINEL_KWARGS` environment variables are used to configure the Redis Sentinel settings. The `DJANGO_SENTINELS` and `CACHES` options are updated accordingly. Additionally, the Celery broker transport options are updated to handle retries when connecting to RabbitMQ.

Related issue: grafana#2312 grafana#4360
Copy link
Contributor

github-actions bot commented Dec 9, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants