Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: allow specific pod annotations for migration job #5170

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

rowieg
Copy link

@rowieg rowieg commented Oct 11, 2024

What this PR does

This pr adds the possibility to add specific annotations to the migration job pod

Motivation

Because Kubernetes jobs and services mesh applications are not that compatible in regards to finishing jobs and removing service mesh sidecar proxy containers these jobs stay forever.

With this change these pods can be explicitly marked via the annotation to skip the service mesh injection

For example:

If you are running a linkerd service mesh all pods within a namespace are automatically injected via an annotation to the namespace.
This leads to Kubernetes jobs to never finish because the proxy is never finished.
To disable this behaviour you can add the "linkerd.io/inject: disabled" annotation to the pod. This skips the injection process for this pod and the job then is finished.

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@rowieg rowieg requested a review from a team October 11, 2024 15:16
@CLAassistant
Copy link

CLAassistant commented Oct 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Dec 7, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants