Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin E2e: Support scenes powered dashboard UI #1155

Merged
merged 10 commits into from
Oct 2, 2024
Merged

Plugin E2e: Support scenes powered dashboard UI #1155

merged 10 commits into from
Oct 2, 2024

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Oct 1, 2024 •
edited by grafana-plugins-platform-bot bot
Loading

What this PR does / why we need it:

Scenes powered dashboards was enabled by default in Grafana recently. This included some changes that broke plugin e2e APIs in some certain scenarios:

  • Panel edit Apply button is renamed to Back to dashboard and there was a new e2e selector for the Back to dashboard button
  • The Add viz button in dashboards only becomes available after first clicking a new Edit button

Unfortunately, these changes were not captured by the API tests in Grafana (apply method was never tested and addPanel was only tested for new dashboards - not already existing ones).

Which issue(s) this PR fixes:

Fixes #1152

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/[email protected]
npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]
yarn add @grafana/[email protected]

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@sunker sunker self-assigned this Oct 1, 2024
@sunker sunker added patch Increment the patch version when merged release Create a release when this pr is merged labels Oct 1, 2024
@sunker sunker marked this pull request as ready for review October 1, 2024 12:15
@sunker sunker requested a review from a team as a code owner October 1, 2024 12:15
@sunker sunker requested review from oshirohugo and mckn and removed request for a team October 1, 2024 12:15
@sunker sunker mentioned this pull request Oct 1, 2024
Closed
4 tasks
jackw
jackw approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@sunker sunker merged commit dbffb7a into main Oct 2, 2024
21 checks passed
@sunker sunker deleted the plugin-e2e/fix-apply-bug branch October 2, 2024 07:25
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/[email protected] 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

@oshirohugo oshirohugo Awaiting requested review from oshirohugo oshirohugo is a code owner automatically assigned from grafana/plugins-platform-frontend

@mckn mckn Awaiting requested review from mckn

Assignees

@sunker sunker

Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Plugins Platform / Grafana Community
Status: 🚀 Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Dashboard Page fixture doens't work properly for dashboardScene feature
2 participants
@sunker @jackw