Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use check-labels to label renovate PRs #1197

Merged
merged 10 commits into from
Oct 10, 2024
Merged

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Oct 10, 2024

What this PR does / why we need it:

This PR removes the default patch label from renovate PRs and updates the check-labels action to label renovate PRs with no-changelog or patch depending on if only the lock file is touched or not. The repos lock file changes don't affect consumers of packages so there is no need for those PRs to create releases or entries in changelogs.

Additionally it removes the cancel-in-progress for the check-labels workflow as we (@ashharrison90 and myself) believe it is confusing renovate by cancelling workflow runs and preventing auto merge from working. Thanks Ash for the help! 🥇

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@jackw jackw self-assigned this Oct 10, 2024
@jackw jackw requested a review from a team as a code owner October 10, 2024 09:22
@jackw jackw requested review from mckn and removed request for a team and mckn October 10, 2024 09:22
Copy link

github-actions bot commented Oct 10, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

@jackw jackw changed the title Ignore: testing some things! CI: Use check-labels to label renovate PRs Oct 10, 2024
@jackw jackw added no-changelog Don't include in changelog and version calculations ci labels Oct 10, 2024
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done spotting this! 🚀

@jackw jackw merged commit eac537e into main Oct 10, 2024
12 of 15 checks passed
@jackw jackw deleted the jackw/auto-renovate-labelling branch October 10, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci no-changelog Don't include in changelog and version calculations
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

2 participants