fix: rideshare tweaks #4075
fix: rideshare tweaks #4075
Conversation
examples/language-sdk-instrumentation/golang-push/rideshare/Dockerfile.load-generator
Outdated
Show resolved
Hide resolved
examples/language-sdk-instrumentation/golang-push/rideshare/docker-compose.yml
Show resolved
Hide resolved
examples/language-sdk-instrumentation/golang-push/rideshare/rideshare/rideshare.go
Show resolved
Hide resolved
examples/language-sdk-instrumentation/golang-push/rideshare/docker-compose.yml
Outdated
Show resolved
Hide resolved
examples/language-sdk-instrumentation/golang-push/rideshare/rideshare/rideshare.go
Show resolved
Hide resolved
examples/language-sdk-instrumentation/golang-push/rideshare/loadgen.go
Outdated
Show resolved
Hide resolved
...s/language-sdk-instrumentation/golang-push/rideshare/prometheus-provisioning/prometheus.yaml
Show resolved
Hide resolved
examples/language-sdk-instrumentation/golang-push/rideshare/rideshare/rideshare.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Hi @shelldandy,
I still see the a.utf8.metric being added. It's breaking the experience in some screens, such as in the metrics explorer, as I showed in the last comment.
When addressing that, could you take the chance to update the branch? Thanks for all the work! 🙂
The metric is still there but without the emoji like before, is that still a problem? I'm only using normal characters in there. I'll update the branch as well no problem |
Yes, "." aren't supported :( 
|
| @@ -358,12 +326,22 @@ func MeterProvider(c Config) (*sdkmetric.MeterProvider, error) { | |||
| } | |||
|
|
|||
| ctx := context.Background() | |||
| exp, err := otlpmetrichttp.New(ctx) | |||
| opts := []otlpmetrichttp.Option{otlpmetrichttp.WithEndpoint(c.OTLPUrl)} | |||
There was a problem hiding this comment.
I've found another issue. I think this is the culprit causing this, since it overrides the OTEL_EXPORTER_OTLP_METRICS_ENDPOINT environment variable configuration:
2025/04/23 07:47:43 failed to upload metrics: Post "http:///api/v1/otlp/v1/metrics": http: no Host in request URL
After the changes, try to run the example to see if the otlp metrics added in this PR #3905 are still available.
There was a problem hiding this comment.
Still seeing the error above when running the example with docker-compose up --build. Could you please take another look? @shelldandy
There was a problem hiding this comment.
I think it should be working properly now, please take another look @marcsanmi
The code was previously only using OTLP_URL for metrics endpoint configuration, which could lead to "no Host in request URL" errors when using OpenTelemetry standard environment variables. This change adds support for the standard OTEL_EXPORTER_OTLP_METRICS_ENDPOINT environment variable while maintaining backward compatibility with OTLP_URL.
|
Hi @shelldandy, I'm still not seeing e.g. the ctx := context.Background()
exp, err := otlpmetrichttp.New(ctx)
if err != nil {
return nil, err
}And it seems to work. I can see both, metrics from #3905 as well as your new utf8 metrics. Would this serve your purpose? Note: For following reviews please ask anyone in @\grafana/pyroscope-team since I'll be out for some weeks. |
Continues from: #4011
Needed to add the utf8 metrics to our prometheus config so they're properly scrapped