Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add duration to callCancelDelayedDownscale logs #185

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add duration to callCancelDelayedDownscale logs #185

merged 1 commit into from
Dec 11, 2024

Conversation

dimitarvdimitrov
Copy link
Contributor

I'm debugging a reconcilliatin which took 20m. I suspect one ingester was blocking the whole reconcile loop.

@dimitarvdimitrov
Add duration to callCancelDelayedDownscale logs
42bb2f0 
I'm debugging a reconcilliatin which took 20m. I suspect one ingester was blocking the whole reconcile loop.
pracucci
pracucci approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach. Never thought about using log.Valuer.

@dimitarvdimitrov dimitarvdimitrov merged commit 2810ba0 into main Dec 11, 2024
6 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/add-duration-to-HTTP-delete-request branch December 11, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimitarvdimitrov @pracucci