Set timeout for k8s HTTP client #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a request to an ingesters take 20m and block the reconiliation loop. We want to avoid that, so adding a timeout. We use this client for both k8s and StatefulSet requests. __I assume the operations that the StatefulSet requests will always be fast and will never have to actually do a lot of work (like uploading blocks). Can the reviewers confirm this assumption?__
pracucci
approved these changes
Dec 10, 2024
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Dec 12, 2024
Specifically, pull in grafana/rollout-operator#186 Signed-off-by: Nick Pillitteri <[email protected]>
4 tasks
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Dec 12, 2024
Specifically, pull in grafana/rollout-operator#186 Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Dec 12, 2024
Specifically, pull in grafana/rollout-operator#186 Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
added a commit
that referenced
this pull request
Dec 13, 2024
Make the timeout added in #186 configurable and default to 5 minutes. Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
added a commit
that referenced
this pull request
Dec 13, 2024
* Make Kubernetes client timeout configurable Make the timeout added in #186 configurable and default to 5 minutes. Signed-off-by: Nick Pillitteri <[email protected]> * Changelog Signed-off-by: Nick Pillitteri <[email protected]> --------- Signed-off-by: Nick Pillitteri <[email protected]>
bjorns163
pushed a commit
to bjorns163/mimir
that referenced
this pull request
Dec 30, 2024
Specifically, pull in grafana/rollout-operator#186 Signed-off-by: Nick Pillitteri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a request to an ingesters take 20m and block the reconiliation loop. We want to avoid that, so adding a timeout. We use this client for both k8s and StatefulSet requests.
I assume the operations that the StatefulSet requests will always be fast and will never have to actually do a lot of work (like uploading blocks). Can the reviewers confirm this assumption?