Add pagination support for Sentry endpoints #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aangelisc
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Hi @olegpixel, these changes LGTM! Just one question in the comments
…github.com/Canva/grafana-sentry-datasource into olegyevik-sentry-datasource-select-project
…github.com/Canva/grafana-sentry-datasource into olegyevik-sentry-datasource-select-project
|
Hey @olegpixel, the build is failing because of an unknown word |
|
Hi @aangelisc, I've updated |
aangelisc
approved these changes
Oct 13, 2023
|
Perfect, thanks again for the contribution @olegpixel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces pagination support for Projects endpoint, enhancing the ability to retrieve data from Sentry's API efficiently.
Sentry Projects Endpoint - https://docs.sentry.io/api/organizations/list-an-organizations-projects/
Sentry Pagination Docs - https://docs.sentry.io/api/pagination/
Link Header - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Link
Changes Made
Added a new FetchWithPagination method in the SentryClient to parse the Link header and extract the next page URL when available, aligning the code with Sentry's pagination guidelines.
Added a new GetAllProjects function to utilise the enhanced Fetch method, enabling it to fetch all projects across multiple pages as needed.
This change will address and resolve the issue described here - #31