fix: Use the recommended 'persist-credentials: false' setting #1143
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub checkout action has this `persist-credentials` setting.
It's described like this:
# Whether to configure the token or SSH key with the local git config
# Default: true
persist-credentials: ''
Sounds harmless, right? It almosts makes it sound as if it's going to
modify `~/.gitconfig`.
This default of `true` causes credentials to end up in the working
copy's `.git/config`, which interacts badly with other stuff happening
in GHA.
Set it to false just in case.
Signed-off-by: Marcelo E. Magallon <[email protected]>
mem
force-pushed
the
mem/persist-credentials-false
branch
from
b772551 to
5bfbdd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub checkout action has this
persist-credentialssetting.It's described like this:
Sounds harmless, right? It almosts makes it sound as if it's going to modify
~/.gitconfig.This default of
truecauses credentials to end up in the working copy's.git/config, which interacts badly with other stuff happening in GHA.Set it to false just in case.