Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "Run agent + chromium as non-root user" #1186

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

The-9880
Copy link
Contributor

@The-9880 The-9880 commented Feb 6, 2025

Reverts #965

Reverting for 2 reasons:

  1. The adduser command is present in the scratch image, which does not have it -- so CI is failing.
  2. The commit message was not taken from the first commit, so feat: is missing. This impacts versioning.

I will un-revert this after it merges and fix both the commit message and the scratch image.

@The-9880 The-9880 requested a review from a team as a code owner February 6, 2025 15:08
@The-9880 The-9880 requested review from d0ugal and nadiamoe February 6, 2025 15:08
@The-9880 The-9880 merged commit 44a7bde into main Feb 6, 2025
5 checks passed
@The-9880 The-9880 deleted the revert-965-docker-non-root branch February 6, 2025 15:12
The-9880 added a commit that referenced this pull request Feb 6, 2025
@sm-release-app sm-release-app bot mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants