Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: increase check timeout to scripted, browser and multihttp checks #1049

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

VikaCep
Copy link
Contributor

@VikaCep VikaCep commented Jan 24, 2025

Closes #1048

  • Allows a timeout of 90 seconds for browser, scripted and multihttp checks
  • Adds validation to prevent frequency lower than the chosen timeout
  • Adds tests
Screen.Recording.2025-01-27.at.17.12.01.mov

@VikaCep VikaCep self-assigned this Jan 24, 2025
@VikaCep VikaCep marked this pull request as ready for review January 27, 2025 20:17
@VikaCep VikaCep requested a review from a team as a code owner January 27, 2025 20:17
@VikaCep VikaCep requested a review from ckbedwell January 27, 2025 20:17
@VikaCep VikaCep changed the title Chore: increase check timeout to scripted, browser and multihttp checks Feat: increase check timeout to scripted, browser and multihttp checks Jan 27, 2025
Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, works perfectly 🙏

@VikaCep VikaCep merged commit df9c5d9 into main Jan 28, 2025
5 checks passed
@VikaCep VikaCep deleted the 1048-increase-timeouts branch January 28, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI support for increased MultiHTTP, scripted and browser timeouts
2 participants