chore: add basic config for stylelint
#996
Draft
+418
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1kman
added
question
|
I think the config looks good for this. Shall we fix all the issues it flags, get it set-up in CI/CD and then merge it in or do you want to do those in separate PRs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces
stylelintto help ensure CSS is written according to our standards and without unintentional errors.We currently have a bunch of bad CSS (in template literals). To not depend on the built-in abilities of some IDEs,
stylelintensures that the quality of our styles is on par with the code that we expect to passeslint.Which issue(s) this PR fixes:
Issues with CSS written as CSS (whether it be inside template literal or in .css files).
How to test
nvm useyarnyarn stylelintNote: this does not address the weak "type safety" of Object style usage of
emotion/cssNote: I expect us to tweak and test
stylelintbefore we (potentially) decide to merge it.