-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update location from where kubectl is downloaded from #1257
Conversation
Seems like the location changed around 1.31.0. The new location also includes the current patch release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
As a next piece of work: it would be better if the version was a variable in the Dockerfile.
Two main reasons:
- It could be updated by Renovate if we adopted that, and then we would get new images as new
kubectl
releases come out, not just when we get a build for another reason. - Image builds would become (a bit more) reproducible: build the same thing, get the same
kubectl
version as last time, not just always the latest - a moving target. That also means if compatibility breaks then we can hold off until it's fixed & previous images can still be built.
Sounds good as a follow-up 🙂 This PR just fixes the status-quo and should end up in the next patch release (ideally in the next couple of days) to get past some SLO check. Will create an issue for the long-term fix 🙂 |
Yeah, that's what I meant with
In case it wasn't clear |
It was mostly clear but the review lacked an approval 😉 |
Ah sorry, I thought I had approved - I did mean to......... |
Seems like the location changed around 1.31.0. The new location also includes the current patch release and thereby updating kubectl to 1.31.3.