Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for new jsx runtime and bump major version #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 commented Jun 17, 2024

prereq for grafana/grafana#88802

won't merge and release until we're all ready in core as well 👍

@ashharrison90 ashharrison90 self-assigned this Jun 17, 2024
@ashharrison90 ashharrison90 changed the title Update to new jsx runtime and bump major version Changes for new jsx runtime and bump major version Jun 17, 2024
@jackw
Copy link
Contributor

jackw commented Jun 19, 2024

won't merge and release until we're all ready in core as well 👍

This package is also used by plugins. If a plugin dev updates this will they need to update their eslint config and webpack config too?

@ashharrison90
Copy link
Contributor Author

won't merge and release until we're all ready in core as well 👍

This package is also used by plugins. If a plugin dev updates this will they need to update their eslint config and webpack config too?

yes. do plugins typically manage their own dependencies, or do they rely on create-plugin to update them? or some mixture of both? 🤔

either way, we should probably add a CHANGELOG to this repo to explain the changes. it will be something like:

  • update eslint-config-grafana as well
  • update the build to use new jsx runtime (this step will vary depending on the existing build, e.g. babel, esbuild, etc.)
  • run the react codemod on the plugin code

Copy link

@tolzhabayev tolzhabayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a concrete plan first on how and especially when we want to tackle the upgrade, so let's have it in place before we make plugin developers do something we don't really know what exactly it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants