Reduce allocs but copy labels where needed.

grafana · Dec 27, 2024 · abb4a42 · abb4a42
1 parent dc2972f
commit abb4a42
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/serialization/appender.go b/serialization/appender.go
@@ -43,7 +43,7 @@ func NewAppender(ctx context.Context, ttl time.Duration, s types.Serializer, log
 // Append metric
 func (a *appender) Append(ref storage.SeriesRef, l labels.Labels, t int64, v float64) (storage.SeriesRef, error) {
 	ts := types.GetMetricFromPool()
-	ts.Labels = l
+	ts.Labels = l.Copy()
 	ts.TS = t
 	ts.Value = v
 	ts.Hash = l.Hash()
@@ -70,7 +70,7 @@ func (a *appender) AppendExemplar(ref storage.SeriesRef, _ labels.Labels, e exem
 	ts := types.GetMetricFromPool()
 	ts.Hash = e.Labels.Hash()
 	ts.TS = e.Ts
-	ts.Labels = e.Labels
+	ts.Labels = e.Labels.Copy()
 	ts.Hash = e.Labels.Hash()
 	err := a.s.SendSeries(a.ctx, ts)
 	return ref, err
@@ -83,7 +83,7 @@ func (a *appender) AppendHistogram(ref storage.SeriesRef, l labels.Labels, t int
 		return ref, nil
 	}
 	ts := types.GetMetricFromPool()
-	ts.Labels = l
+	ts.Labels = l.Copy()
 	ts.TS = t
 	if h != nil {
 		ts.Histogram = h

diff --git a/types/metric.go b/types/metric.go
@@ -66,8 +66,7 @@ func PutMetricIntoPool(m *Metric) {
 	m.Hash = 0
 	m.TS = 0
 	m.Value = 0
-	// We explicitly need this to be nil since labels are not safe to reuse.
-	m.Labels = nil
+	m.Labels = m.Labels[:0]
 	m.Histogram = nil
 	m.FloatHistogram = nil