Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desobekify Credentials #1518

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Desobekify Credentials #1518

merged 7 commits into from
Nov 7, 2024

Conversation

inancgumus
Copy link
Member

What?

  • Desobekify Credentials.
  • Turn Credentials into a value type.

Why?

See "Desobekifying Sobek transformation" at #1064.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@inancgumus inancgumus added refactor stability runtime stability improvements labels Nov 6, 2024
@inancgumus inancgumus self-assigned this Nov 6, 2024
@inancgumus inancgumus mentioned this pull request Nov 6, 2024
Open
@inancgumus inancgumus marked this pull request as ready for review November 6, 2024 19:54
ankur22
ankur22 previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally LGTM 🚀

common/network_manager.go Outdated Show resolved Hide resolved
@inancgumus inancgumus mentioned this pull request Nov 7, 2024
Open
@inancgumus inancgumus force-pushed the fix/test-keyboard-press-test-panic branch from dd098ed to 17a865f Compare November 7, 2024 14:42
@inancgumus inancgumus requested a review from a team as a code owner November 7, 2024 14:42
@inancgumus inancgumus requested review from olegbespalov and joanlopez and removed request for a team November 7, 2024 14:42
Base automatically changed from fix/test-keyboard-press-test-panic to main November 7, 2024 14:42
@inancgumus inancgumus dismissed ankur22’s stale review November 7, 2024 14:42

The base branch was changed.

@inancgumus inancgumus merged commit b58904b into main Nov 7, 2024
21 of 22 checks passed
@inancgumus inancgumus deleted the desobekify/credentials branch November 7, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 left review comments

@olegbespalov olegbespalov Awaiting requested review from olegbespalov olegbespalov is a code owner automatically assigned from grafana/k6-core

@joanlopez joanlopez Awaiting requested review from joanlopez joanlopez is a code owner automatically assigned from grafana/k6-core

Assignees

@inancgumus inancgumus

Labels
refactor stability runtime stability improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22