Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: nettest: add framework for nesting network disruptions in protocols #350

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

roobre
Copy link
Member

@roobre roobre commented Sep 20, 2023

Description

This PR introduces a framework for making reproducible tests using testcontainers that check how network events affect protocols.

For now, it includes a test that checks how a redis application reacts to connections being rejected for a certain period of time and then restored.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have run relevant integration test locally (make integration-xxx for affected packages)
  • I have run relevant e2e test locally (make e2e-xxx for disruptors, or cluster related changes)
  • Any dependent changes have been merged and published in downstream modules

@roobre roobre force-pushed the redis-connection-tests branch 3 times, most recently from acecac3 to c4ea467 Compare September 22, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant