Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Using re-usable CI #42

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Using re-usable CI #42

merged 2 commits into from
Aug 25, 2023

Conversation

olegbespalov
Copy link
Collaborator

What?

This PR standardizes the CI of the xk6-gprc.

The first commit is a minor refactoring, which removes vendor dependency for the tests.

The second commit is stitching CI to the reusable workflow.

Why?

We need to maintain the same standards across different repositories, and it also decreases the maintenance costs.

@olegbespalov olegbespalov self-assigned this Aug 24, 2023
@olegbespalov olegbespalov requested a review from a team as a code owner August 24, 2023 12:43
@olegbespalov olegbespalov requested review from mstoykov and oleiade and removed request for a team August 24, 2023 12:43
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ANd it seems like this will fix #21 instead of the preivous CI update PR

@olegbespalov olegbespalov merged commit 9da0f76 into main Aug 25, 2023
9 checks passed
@olegbespalov olegbespalov deleted the feat/common-ci branch August 25, 2023 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants