Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

google.protobuf.Value tests #56

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

olegbespalov
Copy link
Collaborator

@olegbespalov olegbespalov commented Oct 20, 2023

What?

Add the google.protobuf.Value tests

Why?

We have no tests for the google.protobuf.Value

Updates #55

@olegbespalov olegbespalov requested a review from a team as a code owner October 20, 2023 18:53
@olegbespalov olegbespalov requested review from mstoykov and codebien and removed request for a team October 20, 2023 18:53
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't know if it is expected but here we are testing the case where a Value is returned which means it does mostly Server -> Go -> Binary proto -> Go -> k6 grpc Client. Instead the original issue is more around providing an input: so JS -> JSON -> k6 client -> Binary proto -> ...the rest

@olegbespalov
Copy link
Collaborator Author

@codebien, we do test both input/output.

There is an RPC method:

rpc TestValue(google.protobuf.Value) returns (google.protobuf.Value);

Which uses three times with different inputs (number, string, and boolen), and the server responds based on the input.

@olegbespalov olegbespalov merged commit 49f12ac into main Nov 6, 2023
10 checks passed
@olegbespalov olegbespalov deleted the feat/wrapper-value-tests branch November 6, 2023 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants