feat: allow to configure implicit wait #147
Open
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdaugherty
reviewed
Feb 24, 2025
jdaugherty
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Thank you for the contribution. Let's wait for @matrei to get his thoughts on the config name.
|
camelCase will be great 👍. That is the standard In Grails. |
matrei
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Thanks @JonasPammer! Keep'em coming! I've been away for a couple of days but I'll be more active tomorrow again.
src/testFixtures/groovy/grails/plugin/geb/GrailsGebSettings.groovy
Outdated
Show resolved
Hide resolved
src/testFixtures/groovy/grails/plugin/geb/GrailsGebSettings.groovy
Outdated
Show resolved
Hide resolved
src/testFixtures/groovy/grails/plugin/geb/GrailsGebSettings.groovy
Outdated
Show resolved
Hide resolved
src/testFixtures/groovy/grails/plugin/geb/WebDriverContainerHolder.groovy
Outdated
Show resolved
Hide resolved
matrei
reviewed
Feb 26, 2025
There was a problem hiding this comment.
Thanks for the updates!
I have some more thoughts on this PR:
- There are two additional timeout values:
pageLoadTimeout(default: 300s)andscriptTimeout(default: 30s). I think we should take this opportunity to add support for setting them as well. We could group them undergrails.geb.webdriver.timeouts.*. We should also rename the our variable and config property toimplicitlyWaitto align with the name in Webdriver. - The default value in Webdriver for
implicitlyWaitis0s. I do not know why testcontainers set it to30sin their examples. I would like to try and set the default to0sto resolve the issues the30sdefault causes in Geb. As I understand it @JonasPammer, your testing shows that0sworks fine?
matrei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #134 (comment)
At least for my project, removing it completely results in no errors and 3 minutes (5.0.0-M2; compared to 2m20s without container) instead of 20.
I have yet to figure out a SSCCE that triggers the implicitWait
Sorry for the potential spam of PRs, I want to figure out accepted ways of how to implement things first before tackling my big goal of being able to use GebConfig.groovy (custom environmentized client/driver config + custom remote image) again