Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated mimetypes which are overriding MimeTypesConfiguration #13848

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

codeconsole
Copy link
Contributor

@codeconsole codeconsole commented Nov 18, 2024

The deprecated plugin is overriding the existing configuration. It needs to be removed or disabled.

Fixes

Overriding bean definition for bean 'mimeTypes' with a different definition: replacing [Root bean: class=null; scope=; abstract=false; lazyInit=null; autowireMode=3; dependencyCheck=0; autowireCandidate=true; primary=true; fallback=false; factoryBeanName=org.grails.plugins.web.mime.MimeTypesConfiguration; factoryMethodName=mimeTypes; initMethodNames=null; destroyMethodNames=[(inferred)]; defined in class path resource [org/grails/plugins/web/mime/MimeTypesConfiguration.class]] with [Generic bean: class=org.grails.plugins.web.mime.MimeTypesFactoryBean; scope=singleton; abstract=false; lazyInit=false; autowireMode=0; dependencyCheck=0; autowireCandidate=true; primary=false; fallback=false; factoryBeanName=null; factoryMethodName=null; initMethodNames=null; destroyMethodNames=null]
Overriding bean definition for bean 'grailsMimeUtility' with a different definition: replacing [Root bean: class=null; scope=; abstract=false; lazyInit=null; autowireMode=3; dependencyCheck=0; autowireCandidate=true; primary=true; fallback=false; factoryBeanName=org.grails.plugins.web.mime.MimeTypesConfiguration; factoryMethodName=mimeUtility; initMethodNames=null; destroyMethodNames=[(inferred)]; defined in class path resource [org/grails/plugins/web/mime/MimeTypesConfiguration.class]] with [Generic bean: class=org.grails.web.mime.DefaultMimeUtility; scope=singleton; abstract=false; lazyInit=false; autowireMode=0; dependencyCheck=0; autowireCandidate=true; primary=false; fallback=false; factoryBeanName=null; factoryMethodName=null; initMethodNames=null; destroyMethodNames=null]
Overriding bean definition for bean 'mimeTypeResolver' with a different definition: replacing [Root bean: class=null; scope=; abstract=false; lazyInit=null; autowireMode=3; dependencyCheck=0; autowireCandidate=true; primary=true; fallback=false; factoryBeanName=org.grails.plugins.web.mime.MimeTypesConfiguration; factoryMethodName=mimeTypeResolver; initMethodNames=null; destroyMethodNames=[(inferred)]; defined in class path resource [org/grails/plugins/web/mime/MimeTypesConfiguration.class]] with [Generic bean: class=org.grails.web.mime.DefaultMimeTypeResolver; scope=singleton; abstract=false; lazyInit=false; autowireMode=0; dependencyCheck=0; autowireCandidate=true; primary=false; fallback=false; factoryBeanName=null; factoryMethodName=null; initMethodNames=null; destroyMethodNames=null]

What a nightmare lol.

@codeconsole
Copy link
Contributor Author

#13843

@matrei matrei self-requested a review November 18, 2024 09:38
Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to my tests, Grails 7 built from this branch currently passes grails-functional-tests.

@codeconsole codeconsole merged commit 25a0737 into grails:7.0.x Nov 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants