[Docs] Installation docs for 1.8 #1993
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL)
a discussion (no related file):
I'm blocking merging this PR until Intel publishes noble repo at https://download.01.org/intel-sgx/sgx_repo/ubuntu/
(check the subdirectory in https://download.01.org/intel-sgx/sgx_repo/ubuntu/dists/).
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)
-- commits line 2 at r1:
We typically add v before the version.
-- commits line 5 at r1:
Backticks around this code snippet?
Since apt 2.4, the distro provides /etc/apt/keyrings for user-managed package signing keys and /usr/share/keyrings is recommended for use with keys managed by packages. Debian 11 has older apt, so the directory is not present in the system. I'll leave it as is, instead of adding `mkdir -p`. Signed-off-by: Wojtek Porczyk <[email protected]>
Signing keys were rotated, but only for new distributions, hence 3 extra $(lsb_release -sc). Signed-off-by: Wojtek Porczyk <[email protected]>
woju
force-pushed
the
woju/docs-noble
branch
from
dc7a0c8
to
6fec2d1
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)
-- commits line 10 at r2:
We never use I will leave..., instead we write This commit leaves...
Description of the changes
Because keys for new distros were rotated, the download paths got extra
$(lsb_release -sc).No change for RPM, because there's no
.el10repo.How to test this PR?
Install (for
noble, useunstable-for gramine repo, andmanticfor intel's repo).This change is