[PAL] Fix main() signature in regression tests for UBSan

[woju]

Description of the changes

Split from #1904

How to test this PR?

compile with ubsan on Ubuntu 24.04 and run

---

This change is 

[mkow]

Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)

---

pal/regression/AttestationReport.c line 12 at r1 (raw file):

int main(int argc, char** argv, char** envp) {
    /* We don't care about unused args to main, but UBSan complains otherwise
     * with call through pointer with incorrect function type"

Unmatched " at the end. ditto everywhere

[dimakuv]

Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @mkow and @woju)

---

-- commits line 3 at r1:
I would also add the commit message body:

Newer Clang versions (v18 and newer) added more UBSan checks that
triggered UBSan on PAL regression tests. For more info, see previous
commit "[common] Update UBSan to be compatible with Clang 18".

---

pal/regression/AttestationReport.c line 12 at r1 (raw file):

Previously, mkow (Michał Kowalczyk) wrote…

Unmatched " at the end. ditto everywhere

Yes, should be with "call through pointer ..."

Also, I personally don't like when for 1- or 2-line comments, the ending bracket is on a separate line. I would finish in the same (second) line: ...function type" */

[woju]

Reviewable status: 1 of 17 files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv and @mkow)

---

-- commits line 3 at r1:

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

I would also add the commit message body:

Newer Clang versions (v18 and newer) added more UBSan checks that
triggered UBSan on PAL regression tests. For more info, see previous
commit "[common] Update UBSan to be compatible with Clang 18".

Done.

---

pal/regression/AttestationReport.c line 12 at r1 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

Yes, should be with "call through pointer ..."

Also, I personally don't like when for 1- or 2-line comments, the ending bracket is on a separate line. I would finish in the same (second) line: ...function type" */

Done.

[dimakuv]

Reviewed 16 of 16 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @mkow and @woju)

---

pal/regression/ipv6_parser.c line 1 at r2 (raw file):

/* SPDX-License-Identifier: LGPL-3.0-or-later */ /* Copyright (C) 2022 Intel Corporation

Unintended bug?

[woju]

Reviewable status: 16 of 17 files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv and @mkow)

---

pal/regression/ipv6_parser.c line 1 at r2 (raw file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

Unintended bug?

Fixed. Yes, too much joining lines

[dimakuv]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required) (waiting on @mkow)

[mkow]

Reviewed 15 of 16 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[kailun-qin]

Reviewed 1 of 17 files at r1, 15 of 16 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[woju]

Jenkins, test linux-sgx-vm-gcc-release please

[woju]

Jenkins, test linux-sgx-vm-gcc-release please

[dimakuv]

Reviewable status: complete! all files reviewed, all discussions resolved

[woju]

Jenkins, test linux-sgx-vm-gcc-release please

[dimakuv]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

[kailun-qin]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[mkow]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved