[tests] Add -Wno-implicit-function-declaration for LTP build
#2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently used version of LTP has a bug that results in the following
build error, e.g. when using Clang v18 on Ubuntu 24.04:
clone301.c:136:8: error: call to undeclared function 'pidfd_send_signal'
This is because Clang promoted "implicit function declaration" check
from a warning to an error starting from Clang v16. This commit adds
`-Wno-implicit-function-declaration` flag to CFLAGS during LTP build.
Newer LTP releases fixed this bug, so in the future, when Gramine uses
newer LTP, this commit should be reverted.
Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
dimakuv
commented
Sep 24, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
a discussion (no related file):
This problem only related to Clang. GCC on Ubuntu 24.04 builds fine. Proof:
- LTP build with Clang 18.1
/home/sdp/gramine/libos/test/ltp/src/testcases/kernel/syscalls/clone3/clone301.c:136:8: error: call to undeclared function 'pidfd_send_signal'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
136 | TEST(pidfd_send_signal(pidfd, CHILD_SIGNAL, &uinfo, 0));
- LTP build with GCC 13.2
/home/sdp/gramine/libos/test/ltp/src/testcases/kernel/syscalls/clone3/clone301.c: In function ‘run’:
/home/sdp/gramine/libos/test/ltp/src/testcases/kernel/syscalls/clone3/clone301.c:136:22: warning: implicit declaration of function ‘pidfd_send_signal’; did you mean ‘SYS_pidfd_send_signal’? [-Wimplicit-function-declaration]
136 | TEST(pidfd_send_signal(pidfd, CHILD_SIGNAL, &uinfo, 0));
mkow
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required)
kailun-qin
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Currently used version of LTP has a bug that results in the following build error, e.g. when using Clang v18 on Ubuntu 24.04:
This is because Clang promoted "implicit function declaration" check from a warning to an error starting from Clang v16. This commit adds
-Wno-implicit-function-declarationflag to CFLAGS during LTP build.Newer LTP releases fixed this bug, so in the future, when Gramine uses newer LTP, this commit should be reverted.
Reported by @woju.
How to test this PR?
Build LTP with Clang on Ubuntu 24.04.
This change is