Remove support for older distros #226
Conversation
Signed-off-by: Adarsh Anand <[email protected]>
adarshan-intel
force-pushed
the
adarsh/remove_gsc_distro
branch
from
f57fe2e to
c01c8cc
Compare
Signed-off-by: Adarsh Anand <[email protected]>
|
@kailun-qin Please review |
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @adarshan-intel)
config.yaml.template line 8 at r1 (raw file):
# Currently supported distros are: # - ubuntu:20.04, ubuntu:21.04, ubuntu:22.04, ubuntu:23.04 # - debian:10, debian:11, debian:12
Why debian:11 is being dropped? It's still supported by Gramine project.
Why ubuntu:24.04 is not supported?
Signed-off-by: Adarsh Anand <[email protected]>
There was a problem hiding this comment.
@adarshan-intel The review already started, I've asked you a question in the review. Please engage with the question instead of pinging me.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @adarshan-intel)
There was a problem hiding this comment.
@woju Alright I did not make myself clear. Have added a note here.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @woju)
config.yaml.template line 8 at r1 (raw file):
Why
ubuntu:24.04is not supported?
Have added ubuntu:24.04 in config.yaml.templates,
Why
debian:11is being dropped? It's still supported by Gramine project.
Debian 11 is being removed as discussed in PDT Meeting, it doesn't come under the list of supported distros.
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @mkow)
config.yaml.template line 8 at r1 (raw file):
Previously, adarshan-intel (Adarsh Anand) wrote…
Why
ubuntu:24.04is not supported?Have added
ubuntu:24.04in config.yaml.templates,Why
debian:11is being dropped? It's still supported by Gramine project.Debian 11 is being removed as discussed in PDT Meeting, it doesn't come under the list of supported distros.
@woju - This is based on @mkow suggestion to deprecate distros aggressively to minimize maintenance burden. @mkow - What say keep deb 11?
All clients I track are on Deb 12 already.
There was a problem hiding this comment.
Sure, thanks!
Reviewed 3 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @mkow)
config.yaml.template line 8 at r1 (raw file):
Previously, aneessahib (Anees Sahib) wrote…
@woju - This is based on @mkow suggestion to deprecate distros aggressively to minimize maintenance burden. @mkow - What say keep deb 11?
All clients I track are on Deb 12 already.
IIUC @mkow was talking about distros not supported by Gramine itself. Gramine supports Debian 12 and 11 (for about half a year, until release of trixie, which will happen around July 2025 I think).
So debian:10 rightfully goes away, but not debian:11.
Signed-off-by: Adarsh Anand <[email protected]>
There was a problem hiding this comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @mkow and @woju)
config.yaml.template line 8 at r1 (raw file):
Previously, woju (Wojtek Porczyk) wrote…
IIUC @mkow was talking about distros not supported by Gramine itself. Gramine supports Debian 12 and 11 (for about half a year, until release of
trixie, which will happen around July 2025 I think).So
debian:10rightfully goes away, but notdebian:11.
Keeping debian:11 in the latest fixup commit
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL), "fixup! " found in commit messages' one-liners
There was a problem hiding this comment.
Reviewed 3 of 5 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, "fixup! " found in commit messages' one-liners
|
Can we merge this? |
There was a problem hiding this comment.
Reviewed 3 of 5 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, "fixup! " found in commit messages' one-liners (waiting on @adarshan-intel)
test/README.rst line 33 at r3 (raw file):
cd .. docker build --tag ubuntu22.04-bash --file test/ubuntu22.04-bash.dockerfile .
Could we advertise 24.04 instead? It's newer, we shouldn't suggest people to start with an older distro because it will be deprecated sooner.
Description of the Changes
This pull request removes support for older distributions from the GSC
config.yaml.templateand associated documentation. The following distributions have been removed:Ubuntu: 21.04, 20.04, 23.04
Debian: 10
CentOS: 8
Documentation/index.rst: Updated to reflect the current supported distributions.
config.yaml.template: Removed references to the unsupported distributions.
test/README.rst: Modified Docker build and test commands to utilize Ubuntu 22.04.
How to Test this PR
CI
This change is