-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add customizable fetch function to ApiClientOptions #655
Conversation
Can you explain a use case for a custom fetch function? |
This PR gives a possibility to use native |
That's a great point. I might remove this again for 2.0 when we migrate to native fetch, we'll see. Either way, I'll open an issue about it first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@IKatsuba consider signing your commits in the future. We usually require this from all contributors, but I made an exception now. @all-contributors add @IKatsuba for the idea and the code! |
I've put up a pull request to add @IKatsuba! 🎉 |
@IKatsuba do you have time to fix up your changes? |
I will research it during the day today |
Epic, thank you! |
This pull request introduces a new feature to the
ApiClient
class insrc/core/client.ts
to allow customfetch
functions. This enables more flexibility in making HTTP requests, especially in different environments like Node.js and Deno.