fix: Ensure the DB is still "cleaned" even when transactions are not used #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used In some tests, we might ensure that a transaction has been rolled back (e.g. if an error occurred). Since currently we do not support transactions within other transactions, those tests use the `omit_database_transaction` flag which means the test does not get wrapped in a transaction. The problem is that these tests now leave data lying around after running. Our original plan to solve this was to find a way to still rollback in the app despite already running in a transaction. However Sequel does not support naming a transaction from what I can tell, and anyway there is no way to pass args to the transaction via the `DatabaseCleaner` gem. Going through some issues I found this issue: DatabaseCleaner/database_cleaner#652 Basically this person wants to read data from the DB in another app, but in only some tests. He took the approach of switching "strategy" to accomplish it. I am basically stealing the same idea since it seems to work and was quite trivial. The big downside is that those tests will probably take longer to run, luckily only 5 tests use this flag currently in echo, so this should not be too big of a problem.
kjellm
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some tests, we might ensure that a transaction has been rolled back (e.g. if
an error occurred). Since currently we do not support transactions within other
transactions, those tests use the
omit_database_transactionflag which meansthe test does not get wrapped in a transaction. The problem is that these tests
now leave data lying around after running.
Our original plan to solve this was to find a way to still rollback in the app
despite already running in a transaction. However Sequel does not support naming
a transaction from what I can tell, and anyway there is no way to pass args to
the transaction via the
DatabaseCleanergem. Going through some issues I foundthis issue:
DatabaseCleaner/database_cleaner#652
Basically this person wants to read data from the DB in another app, but in only
some tests. He took the approach of switching "strategy" to accomplish it. I am
basically stealing the same idea since it seems to work and was quite trivial.
The big downside is that those tests will probably take longer to run, luckily
only 5 tests use this flag currently in echo, so this should not be too big of a
problem.