Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flatpak manifest #35

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

a-andre
Copy link

@a-andre a-andre commented Mar 9, 2024

No description provided.

@OzarkShepherd
Copy link
Collaborator

Thank you so much for updating the dependencies. Since you know a way to remove the no-pep517 command, would you be able to add pygraphviz back in? https://github.com/pygraphviz/pygraphviz Pygraphviz is needed for one of the addons, I think network chart.

I see you saw that the own-name is necessary due to gramps using a hyphen instead of underscore, so does that mean you ran a workflow and have a gramps.flatpak file to test? I didn't see it at your repository, so would you add the file to the pull request after adding pygraphviz if possible?

@a-andre
Copy link
Author

a-andre commented Mar 9, 2024

I can add pygraphviz but I don't know how to test as the network chart addon seems to be no longer available (I couldn't find it with the addon manager).

Gramps no longer uses the hyphen (gramps-project/gramps@2b50f55) that's why I removed the own-name arg.

@Nick-Hall
Copy link
Member

I can add pygraphviz but I don't know how to test as the network chart addon seems to be no longer available (I couldn't find it with the addon manager).

Try searching with the Audience set to "Expert".

@OzarkShepherd
Copy link
Collaborator

That's fine about pygraphviz, I don't actually know if network chart is no longer compatible with 5.2, or if it doesn't show up due to the flatpak not having the required pygraphviz prerequisite.

Would you add the gramps.flatpak you have from the Actions workflow? I just want to verify that the updates didn't break anything. I need to start adding the archive with the "Paste, drop, or click to add files" link also when I do PR's.

@OzarkShepherd
Copy link
Collaborator

I just noticed the 25 MB attachment limit makes my request unfeasible, so I'll check the archive soon another way.

@OzarkShepherd
Copy link
Collaborator

Thank you a-andre , I didn't notice any problems with the updated dependencies. Spell check works, edit exif still works, graphview still works.

So since it is not a bug fix (unlike the data directories I'm troubleshooting in another PR) I guess this can be merged on Saturday 16 March to give more time for others to review?

Copy link
Collaborator

@OzarkShepherd OzarkShepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

geocode glib master changed upstream and needs a new sha256sum

@@ -154,15 +141,15 @@ modules:
url: https://gitlab.gnome.org/GNOME/geocode-glib/-/archive/master/geocode-glib-master.tar.gz
sha256: 9ec6747d31fee70e5b7ede079f63402b67c21c329ade1d8a8ef9c76de5136901
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

geocode glib master changed 2 days ago on March 16, which changed the sha256sum. So the sha256sum has to be changed here to compile and push this update for the Gramps flatpak.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the URL to a permanent link

André Apitzsch added 2 commits March 18, 2024 19:05
* intltool has been replaced by gettext, which is part of the runtime
* gtkspell has been replaced by gspell
Upstream changed name to 'org.gramps_project.Gramps' [1].

[1] gramps-project/gramps@2b50f55
@OzarkShepherd OzarkShepherd merged commit 826f38d into gramps-project:main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants