Update descendreport.py #1817
Closed
Update descendreport.py #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to insert a gender symbol before the person's name
|
We only accept bug fixes in the maintenance branches. Please rebase this onto the master branch. |
|
Sorry for my understanding. I thought it was the opposite. I will do the
PR to the master branch.
…On Sat, Dec 7, 2024, 8:32 AM Nick Hall ***@***.***> wrote:
We only accept bug fixes in the maintenance branches. Please rebase this
onto the *master* branch.
—
Reply to this email directly, view it on GitHub
<#1817 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2TV3N4I654CPAW5XQNXE32EMBHJAVCNFSM6AAAAABTGHRP46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVGE4DSNRVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
See the Branches section in our committing policies for more details. |
|
I just resubmitted 3 new PRs (1818,1819,1820) targeting this time
gramps-project:master. Hope they cause no more trouble. Thanks.
…On Sat, Dec 7, 2024 at 9:05 AM Nick Hall ***@***.***> wrote:
See the *Branches* section in our committing policies
<https://gramps-project.org/wiki/index.php/Committing_policies> for more
details.
—
Reply to this email directly, view it on GitHub
<#1817 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2TV3N25YLFXO3AMMIVXML2EMFD7AVCNFSM6AAAAABTGHRP46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVGE4TQOBWGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Dave Khuon
|
|
… On Sun, Dec 8, 2024, 8:04 AM Nick Hall ***@***.***> wrote:
Closed #1817 <#1817>.
—
Reply to this email directly, view it on GitHub
<#1817 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2TV3MPNI3UNBQTPV336AL2ERGX3AVCNFSM6AAAAABTGHRP46VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGU3TEOBXGIZDINY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Wait for the pull requests to be reviewed. To make the review easier (a suggestion from me only) is to document the change on each pull request by providing a screenshot of the change (highlighted if need be) and example of the output result. Another suggestion is that the title for each pull request be changed to reflect what it is for rather than just stating the file it is changing eg "Update descendreport.py" could be ""Descendant Report" Support gender symbol before the person's name" etc... Thanks for sticking with the submission process 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to insert a gender symbol before the person's name