Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix n_nodes counting #10

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix n_nodes counting #10

merged 1 commit into from
Aug 6, 2024

Conversation

AlCatt91
Copy link
Collaborator

@AlCatt91 AlCatt91 commented Aug 5, 2024

Fix issues with how the number of nodes in the graph was computed in the composition_count routine, which threw errors if the dataframe contained more columns than just h,r,t.
Also added an extra (inconsequential) column in the dataframes for unit testing.

@AlCatt91 AlCatt91 requested a review from danjust August 5, 2024 17:12
Copy link
Collaborator

@sbonner0 sbonner0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the fix!

Copy link
Contributor

@danjust danjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Alberto

@AlCatt91 AlCatt91 merged commit a442940 into main Aug 6, 2024
1 check passed
@AlCatt91 AlCatt91 deleted the fix_n_nodes branch August 6, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants