Refactoring special function implementations #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awf
approved these changes
Sep 29, 2023
|
|
||
| @pytest.mark.parametrize("binom_func", [binom_beta, binom_fori, binom_lookup]) | ||
| def test_binom(binom_func): | ||
| x = jnp.array([4, 4, 4, 4]) |
There was a problem hiding this comment.
Maybe test some edge cases too (1,1) (3,3) (3,0) (0,-1) etc
There was a problem hiding this comment.
good idea, I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds additional implementations of the special functions used in the integral evaluation methods. Also revisited the
binom_factorimplementation to avoid thefori_loop.The motivation to provide different implementations is to allow comparing across different metrics such as:
A separate PR to come will introduce measurements across these metrics.