Add binom factor notebook #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
hatemhelal
reviewed
Oct 10, 2023
| @@ -0,0 +1,521 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #5. print("# AUTOGENERATED from notebooks/binom_factor_table.ipynb", file=f)
I think the linters are complaining as this doesn't have a copyright and fails the black formatter. Could you try changing this to:
print("# Copyright (c) 2023 Graphcore Ltd. All rights reserved.", file=f)
print("# AUTOGENERATED from notebooks/binom_factor_table.ipynb", file=f)
print("# fmt: off", file=f)
Reply via ReviewNB
|
Neat solution, I remembered another reference that has a derivation for the binomial factor: http://arxiv.org/abs/2007.12057 I think the double summation in 2.45 might be useful comparison here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function called "binom factor" is one of those with a variable-sized loop,
which is tricky to vectorize. This notebook shows a strategy that might be helpful.