Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pmap nanodft #84

Merged
merged 10 commits into from
Sep 16, 2023
Merged

Pmap nanodft #84

merged 10 commits into from
Sep 16, 2023

Conversation

AlexanderMath
Copy link
Contributor

No description provided.

AlexanderMath and others added 5 commits September 14, 2023 11:57
@AlexanderMath
Merge branch 'main' into pmap_nanodft
34f65b6
pass N to indices_func
d0b19f1
refactored jnp.take and jax.lax.segment_sum into jax.lax.gather and j…
affd1c3 
…ax.lax.scatter_add, which we should be able tmap and thus control tile memory layout/comms and make 10x faster.
..
7476f15
fixing bug
3dbd0e0
awf
awf approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@awf awf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good changes - at some point, it would be good to have only one "nanoDFT", even if it includes pmap...

@AlexanderMath
Copy link
Contributor Author

AlexanderMath commented Sep 15, 2023 •
edited
Loading

it would be good to have only one "nanoDFT", even if it includes pmap...

Exactly.

@AlexanderMath AlexanderMath merged commit 6e21f21 into main Sep 16, 2023
1 check passed
@AlexanderMath AlexanderMath deleted the pmap_nanodft branch September 16, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awf awf awf approved these changes

@blazejba blazejba Awaiting requested review from blazejba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderMath @awf