-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Householder reduction to Hessenberg form #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to you on how you want to do it, but I am happy if you want to merge the initial implementation of Hessenberg, and then work on the for_iloop
version in a new PR/branch. Just need a small unit test before merging (like checking vs Numpy).
Personally a big fan of short PR quickly merged :)
Btw, for the CI to pass, you'll need to run the |
I made the changes as per the comments above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paolot-gc , looking great 👍
This branch implements reduction to Hessenberg form using Householder reflections. It makes use of the vertices developed for the QR decomposition.