IPU Jacobi eigh decomposition fori_loop transition
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balancap
force-pushed
the
ipu-jacobi-eigh-fori-loop-implementation
branch
from
648afaa to
736e9b0
Compare
balancap
changed the title
fori_loop transition
balancap
force-pushed
the
ipu-jacobi-eigh-fori-loop-implementation
branch
2 times, most recently
from
209ea98 to
905d482
Compare
This PR is switching the IPU Jacobi `eigh` implementation from a Python loop to a JAX `fori_loop`, reducing massively code size and allowing Eigen decomposition on larger matrices. Note: in terms of performance, some issues still remain as Poplar compiler is adding some extra on-tile copies which in theory could be eluded.
balancap
force-pushed
the
ipu-jacobi-eigh-fori-loop-implementation
branch
from
905d482 to
8617eb2
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is switching the IPU Jacobi
eighimplementation from aPython loop to a JAX
fori_loop, reducing massively code size andallowing Eigen decomposition on larger matrices.
Note: in terms of performance, some issues still remain as Poplar
compiler is adding some extra on-tile copies which in theory could
be eluded.