-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Hessenberg: Use fori_loop() instead of python for-loop #43
Conversation
The crash was due to memory not being aligned properly. I fixed the issue by slapping a MIN_ALIGN on all vertex Vectors (as suggested by @balancap). I compiled and it ran correctly with size 736. On the plus side, the compile time is just 55s (vs. 15 minutes) and the memory usage is much smaller than for the unrolled-loop version. |
With the use of the |
In the Hessenberg transformation, this PR replaces the python for-loop that scan the columns of the matrix with a jax.lax.fori_loop().
Avoids code bloating associated with the loop unrolling of the python for-loop.
In its first version, this PR does not use the "smart indexing" that avoids some matrix processing.
Currently, the code crashes for sizes larger than 128x128.