Fix IPU Jacobi eigh algorithm when size % 4 == 2 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balancap
force-pushed
the
fix-ipu-jacobi-eigh-size-10
branch
from
6ea2fdd to
5ca7014
Compare
The recent improvement in PR #49 introduced a regression in Jacobi `eigh`, raising an error when size % 4 == 2. This is due to the partial loop unrolling in Jacobi second update stage. This PR is fixing the issue by passing explicitely the offset and size of the workload to the vertex.
balancap
force-pushed
the
fix-ipu-jacobi-eigh-size-10
branch
from
5ca7014 to
1a8d53e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent improvement in PR #49 introduced a regression in Jacobi
eigh, raising an error when size % 4 == 2. This is due to the partial loop unrolling in Jacobi second update stage.This PR is fixing the issue by passing explicitely the offset and size of the workload to the vertex.