-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gisgraphy Geocoder #34
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f345ef9
Add Gisgraphy geocoder
gisgraphy 20b2b8a
remove unused function
gisgraphy 35175dd
Put Config param to URL (in uppercase)
gisgraphy dca79af
update dto for better zipcode management for label
gisgraphy 6e8588f
Update README.md
gisgraphy 17b219b
update label to take the value returned by the server (Some modification
gisgraphy fb671a5
Merge branch 'master' of https://github.com/gisgraphy/geocoder-conver…
gisgraphy ebf52e3
update label
gisgraphy da642c5
reformat code (tabs=>space)
gisgraphy 4a512aa
clean code
gisgraphy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,17 @@ | ||
nominatimUrl: http://nominatim.openstreetmap.org/search/ | ||
nominatimReverseUrl: http://nominatim.openstreetmap.org/reverse/ | ||
nominatimURL: http://nominatim.openstreetmap.org/search/ | ||
nominatimReverseURL: http://nominatim.openstreetmap.org/reverse/ | ||
nominatim: true | ||
nominatimEmail: | ||
|
||
openCageDataUrl: https://api.opencagedata.com/geocode/v1/json | ||
openCageDataURL: https://api.opencagedata.com/geocode/v1/json | ||
openCageDataKey: | ||
openCageData: false | ||
|
||
gisgraphyGeocodingURL: https://services.gisgraphy.com/geocoding/ | ||
gisgraphyReverseGeocodingURL: https://services.gisgraphy.com/reversegeocoding/ | ||
gisgraphySearchURL: https://services.gisgraphy.com/fulltext/ | ||
gisgraphyAPIKey: | ||
|
||
# e.g. to restrict for local access | ||
# ipWhiteList:"localhost,127.0.0.1" | ||
ipWhiteList: "" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to check the formatting? Sometimes there are 2 or 3 lines between methods. Is there a reason for this or can we just use one empty line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also there is a change for this whole file, probably because of tabs vs spaces. It would be great if we could keep the changeset as small as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do it separately. I use Eclipse and appreciate if you can do it in another commit. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I done it but not sure it is correct