Skip to content

Hide paths while pressing the "h" key or press a small icon #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ratrun
Copy link
Contributor

@ratrun ratrun commented Jun 7, 2025

Implement the suggested solution for #334. While pressing the "h" key, the paths are removed such that one can see the map details of the roads. Additionally, a small button next right to the map attribution also hides or shows again the paths.

Please review and provide feedback if there is a chance that this gets merged. Currently, the translation for the button tool tip is missing as I didn't want to change the spreadsheet as I don't know if this can get merged.

@ratrun
Copy link
Contributor Author

ratrun commented Jun 8, 2025

The absolute positioning of the button is problematic with other attribution lengths. It only works with the Openstreetmap map currently. I don't know how to fix this properly. Moving it to the left of the attribution would be easy.

@karussell
Copy link
Member

Why is a button necessary? We could document it in keyboard shortcuts or something.

@ratrun
Copy link
Contributor Author

ratrun commented Jun 20, 2025

Why is a button necessary? We could document it in keyboard shortcuts or something.

Without an explicit button (which indicates the respective shortcut key) nobody will figure out that this feature exists. And who reads a documentation about shortcuts? I didn't even know that such documentation exists 🥲

@ratrun
Copy link
Contributor Author

ratrun commented Jun 20, 2025

In the meantime I moved the button to the left of the attribution. Please check!

@karussell
Copy link
Member

I don't like it to be honest and don't want to clutter the UI for such a niche feature. What is the plan if we add more shortcuts? I don't think we should add more buttons...

@ratrun ratrun force-pushed the hidetrackwithkey branch from fcab815 to 38f0e9c Compare June 20, 2025 16:22
@ratrun
Copy link
Contributor Author

ratrun commented Jun 20, 2025

Ok, so I removed the button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants