Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to detect bad plan resolvers sooner #1886

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Dec 9, 2023

Description

Plan resolvers should return a step (or null); sometimes people forget the return statement and this can lead to misleading errors. Attempt to give a more sensible error up front.

Performance impact

Planning only.

Security impact

None known.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Dec 9, 2023

🦋 Changeset detected

Latest commit: f3f4592

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
graphile-utils Patch
grafast Patch
postgraphile Patch
@localrepo/grafast-bench Patch
@dataplan/json Patch
@dataplan/pg Patch
@grafserv/persisted Patch
grafserv Patch
ruru-components Patch
@localrepo/grafast-website Patch
graphile-build-pg Patch
graphile-build Patch
pgl Patch
graphile-export Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit 2946eb8 into main Dec 11, 2023
24 checks passed
@benjie benjie deleted the catch-plan-resolver-errors branch December 11, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant