Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODO from make-add-pg-table-condition-plugin.md #2342

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

jcgsville
Copy link
Contributor

I tested it by creating a nearly identical plugin in my Postgraphile project. It works. TODO no longer necessary unless you wanted some more rigorous or automated testing or something

Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: dfe8325

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome; thanks!

@benjie benjie merged commit da75689 into graphile:main Jan 29, 2025
21 checks passed
@jcgsville jcgsville deleted the patch-2 branch January 29, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants