Sync Django version with requirements.txt #2873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a dependency issue when installing with pip from a tarball. Found using Python 3.13, which removed the 'cgi' module, required for Django 3.2.
|
Well, thanks for your contribution but 3.13 is not single supported version, I'm afraid. 3.8 can be removed, but even 3.9 is still supported by some distros. |
|
Ah, sorry, I changed requirements already. Ok, let me fix tests then. Master would not be compatible with old versions, indeed |
|
@UweMenges : sorry for confusion. Unfortunately, I was forced to include your fix to #2874 (because tests using setup.py, d-oh) and I did it without proper attribution of your code. You can try to rebase but I suspect it will be noop now. I would like to include your change to CHANGELOG anyway. |
|
Closing pull request as the relevant code change went in with #2874. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a dependency issue when installing with pip from a tarball. Found using Python 3.13, which removed the 'cgi' module, required for Django 3.2.