Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more unused modules #736

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ These are categorised as either "Reconstruction challenges" that are considered

## :handshake: Contributing

To make sure that the process of contributing is as smooth and effective as possible, we provide a few guidelines in the [contributing guide](CONTRIBUTING.md) that we encourage contributors to follow.
To make sure that the process of contributing is as smooth and effective as possible, we provide a few guidelines in the [contributing guide](docs/source/contribute/contribute.rst) that we encourage contributors to follow.

In short, everyone who wants to contribute to this project is more than welcome to do so! Contributions are handled through pull requests, that should be linked to a [GitHub issue](https://github.com/graphnet-team/graphnet/issues) describing the feature to be added or bug to be fixed. Pull requests will be reviewed by the project maintainers and merged into the main branch when accepted.

Expand Down
2 changes: 1 addition & 1 deletion src/graphnet/data/dataconverter.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Contains `DataConverter`."""

from typing import List, Union, OrderedDict, Dict, Tuple, Any, Optional, Type
from typing import List, Union, OrderedDict, Dict, Tuple, Any, Optional
from abc import ABC

from tqdm import tqdm
Expand Down
1 change: 0 additions & 1 deletion src/graphnet/data/sqlite/deprecated_methods.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from graphnet.data.extractors.icecube import I3Extractor
from graphnet.data.extractors.icecube.utilities.i3_filters import (
I3Filter,
NullSplitI3Filter,
)
from graphnet.data import I3ToSQLiteConverter

Expand Down
1 change: 0 additions & 1 deletion src/graphnet/models/components/layers.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from torch_geometric.typing import Adj, PairTensor
from torch_geometric.nn.conv import MessagePassing
from torch_geometric.nn.inits import reset
from torch_geometric.data import Data
import torch.nn as nn
from torch.nn.functional import linear
from torch.nn.modules import TransformerEncoder, TransformerEncoderLayer
Expand Down
2 changes: 0 additions & 2 deletions src/graphnet/models/components/pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@
from torch_scatter import scatter, scatter_std

from torch_geometric.nn.pool import (
avg_pool,
max_pool,
avg_pool_x,
max_pool_x,
)

Expand Down
2 changes: 1 addition & 1 deletion src/graphnet/models/gnn/icemix.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def __init__(
add_norm_layer=True,
skip_readout=True,
)
elif include_dynedge and not (dynedge_args is None):
elif include_dynedge and dynedge_args is not None:
self.dyn_edge = DynEdge(**dynedge_args)

self.include_dynedge = include_dynedge
Expand Down
2 changes: 1 addition & 1 deletion src/graphnet/models/standard_model.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Standard model class(es)."""

from typing import Any, Dict, List, Optional, Union, Type
from typing import Dict, List, Optional, Union, Type
import torch
from torch import Tensor
from torch_geometric.data import Data
Expand Down
1 change: 0 additions & 1 deletion src/graphnet/training/callbacks.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import warnings

import numpy as np
import torch
from tqdm.std import Bar

from pytorch_lightning import LightningModule, Trainer
Expand Down
1 change: 0 additions & 1 deletion src/graphnet/training/loss_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
from torch import nn
from torch.nn.functional import (
one_hot,
cross_entropy,
binary_cross_entropy,
softplus,
)
Expand Down
1 change: 0 additions & 1 deletion src/graphnet/utilities/config/base_config.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""Base config class(es)."""

from abc import abstractmethod
from collections import OrderedDict
import inspect
import sys
Expand Down
Loading