Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRST audit fixes for data service contracts #1076

Open
wants to merge 7 commits into
base: horizon
Choose a base branch
from

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Dec 3, 2024

This PR addresses the following findings:

  • TRST-L-1 DataService cannot be initialized using __DataService_init_unchained() unlike stated in docs
  • TRST-L-13 Allocations could be created with a provision below the minimum valid amount
  • TRST-R-3 Verify state transitions
  • TRST-R-4 Lack of storage slots in upgradeable contracts
  • TRST-R-5 Equivalent contracts behave differently
  • TRST-R-6 Protect from developer errors by improving docs of inheriting contracts

@tmigone tmigone force-pushed the tmigone/trust-fixes-data-service branch from 62c4209 to 2e10813 Compare December 3, 2024 15:12
Copy link

openzeppelin-code bot commented Dec 3, 2024

TRST audit fixes for data service contracts

Generated at commit: 4d62209eafed4bc5aafe2d64413f38b11a7d8e64

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
40
61
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@tmigone tmigone force-pushed the tmigone/trust-fixes-data-service branch from 5c83562 to 29ed2e6 Compare December 4, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants