Skip to content

fix: add horizon and subgraph-service as dependencies to toolshed #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

pcarranzav
Copy link
Member

Summary

  • Add @graphprotocol/horizon and @graphprotocol/subgraph-service as workspace dependencies to the toolshed package
  • Uses workspace:^ protocol to ensure local packages are used during development and proper versions are resolved when published

Test plan

  • Dependencies added to package.json
  • Verify toolshed builds correctly with new dependencies
  • Verify published package will resolve dependencies correctly

🤖 Generated with Claude Code

Copy link

openzeppelin-code bot commented Jul 25, 2025

fix: add horizon and subgraph-service as dependencies to toolshed

Generated at commit: f646158566346db7b55ab9990780504d4d611ec4

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
39
60
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@pcarranzav
Copy link
Member Author

Actually, this doesn't work because it creates a circular dependency

Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​graphprotocol/​subgraph-service@​0.4.180100939370
Added@​graphprotocol/​horizon@​0.4.180100939670

View full report

Copy link

codecov bot commented Jul 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.84%. Comparing base (523d3b1) to head (f646158).
⚠️ Report is 5 commits behind head on horizon.

Additional details and impacted files
@@           Coverage Diff            @@
##           horizon    #1210   +/-   ##
========================================
  Coverage    82.84%   82.84%           
========================================
  Files           47       47           
  Lines         2093     2093           
  Branches       620      620           
========================================
  Hits          1734     1734           
  Misses         359      359           
Flag Coverage Δ
unittests 82.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcarranzav pcarranzav closed this Jul 28, 2025
@pcarranzav pcarranzav deleted the fix/toolshed-horizon-deps branch July 28, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant