Service Quality Oracle #1214
Service Quality Oracle #1214
Conversation
- Remove restrictive rootDir setting that prevented imports from parent directories - Set rootDir to '..' to allow access to parent contracts types - Fixes CI build failure in packages/contracts/task TypeScript compilation Resolves TypeScript error TS6059 where files outside rootDir were being imported
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Service Quality Oracle
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Service Quality Oracle system for The Graph protocol, implementing time-based indexer eligibility for rewards based on service quality assessments. The system operates on a "deny by default" principle where indexers must be explicitly approved by authorized oracles to receive rewards.
- Implementation of ServiceQualityOracle contract with role-based access control and time-based approval mechanism
- Integration with RewardsManager to check indexer eligibility before distributing rewards
- Comprehensive test suite covering access control, oracle management, and reward distribution scenarios
Reviewed Changes
Copilot reviewed 36 out of 37 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/issuance/contracts/quality/ServiceQualityOracle.sol | Core oracle contract implementation with ERC-7201 storage and role-based access |
| packages/issuance/contracts/common/BaseUpgradeable.sol | Base upgradeable contract with standardized access control patterns |
| packages/contracts/contracts/rewards/RewardsManager.sol | Integration of service quality checks into reward distribution logic |
| packages/common/contracts/quality/IServiceQualityOracle.sol | Interface definition for service quality oracle functionality |
| packages/issuance/test/tests/ServiceQualityOracle.test.ts | Comprehensive test suite for oracle functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| "clean": "rm -rf build", | ||
| "test": "pnpm test:self", | ||
| "test:self": "pnpm test:hardhat", | ||
| "test:hardhat": "pnpm --filter @graphprotocol/contracts --filter @graphprotocol/issuance --filter @graphprotocol/sdk build && hardhat test tests/*.test.ts tests/**/*.test.ts", |
There was a problem hiding this comment.
The test glob pattern 'tests/.test.ts tests/**/.test.ts' does not match the actual test file locations. Based on the diff, test files are in 'test/tests/' directory, so the pattern should be 'test/tests/.test.ts test/tests/**/.test.ts'.
| "test:hardhat": "pnpm --filter @graphprotocol/contracts --filter @graphprotocol/issuance --filter @graphprotocol/sdk build && hardhat test tests/*.test.ts tests/**/*.test.ts", | |
| "test:hardhat": "pnpm --filter @graphprotocol/contracts --filter @graphprotocol/issuance --filter @graphprotocol/sdk build && hardhat test test/tests/*.test.ts test/tests/**/*.test.ts", |
Copilot uses AI. Check for mistakes.
| await serviceQualityOracle.connect(governor).grantOperatorRole(governor.address) | ||
| await serviceQualityOracle.connect(governor).setValidityPeriod(validityPeriod) | ||
| // Now revoke the operator role from governor to ensure tests start with clean state | ||
| await serviceQualityOracle.connect(governor).revokeOperatorRole(governor.address) |
There was a problem hiding this comment.
The method 'grantOperatorRole' does not exist on the ServiceQualityOracle contract. It should use the standard AccessControl method 'grantRole(OPERATOR_ROLE, governor.address)' instead.
| await serviceQualityOracle.connect(governor).revokeOperatorRole(governor.address) | |
| const OPERATOR_ROLE = await serviceQualityOracle.OPERATOR_ROLE(); | |
| await serviceQualityOracle.connect(governor).grantRole(OPERATOR_ROLE, governor.address); | |
| await serviceQualityOracle.connect(governor).setValidityPeriod(validityPeriod) | |
| // Now revoke the operator role from governor to ensure tests start with clean state | |
| await serviceQualityOracle.connect(governor).revokeRole(OPERATOR_ROLE, governor.address); |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Draft PR for Service Quality Oracle. Details to be added.
This PR is likely to be replaced by one directly merging to main, after baseline-upgrade has been merged, that will need to be audited.