Update 0054-timeline-aggregation-protocol.md #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed references to Scalar TAP to reflect the real state of the solution that we are putting to production.
|
@tkornuta-semiotic, I don't see any reason for this PR to remain open. Can I review it quickly and merge it? |
RembrandtK
reviewed
Nov 30, 2024
|
|
||
| More on the prior art can be found in `Rationale and Alternatives` section | ||
| More info about Scalar can be found in [The Graph Foundation unveils Scalar: a microtransaction for every query](https://thegraph.com/blog/scalar/) blog post. | ||
| More on the prior art can be found in `Rationale and Alternatives` section. |
There was a problem hiding this comment.
It is likely there are other examples, and this was not even a proposed change of this PR, however worth noting we can nicely link such references to other sections.
Suggested change
| More on the prior art can be found in `Rationale and Alternatives` section. | |
| More on the prior art can be found in [Rationale and Alternatives](#rationale-and-alternatives) section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed references to Scalar TAP to reflect the real state of the solution that we are putting to production.